Skip to content

TEST: Ignore atime in test_filemanip.test_recopy #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2016

Conversation

effigies
Copy link
Member

From #1617, comparing stat on an unchanged file can falsely indicate a change if the filesystem sets atimes.

The first commit uses a helper function to cause tests to always span a clock tick, to demonstrate that all test-timing-related bugs (e.g. #1586) are handled, so we don't have to keep coming back to this.

The second commit removes the delays so that the tests run in <1s instead of ~13s.

Given that this follows on #1391, #1570 and #1586, no changelog entry.

@codecov-io
Copy link

codecov-io commented Sep 14, 2016

Current coverage is 70.88% (diff: 100%)

Merging #1634 into master will decrease coverage by <.01%

@@             master      #1634   diff @@
==========================================
  Files          1019       1019          
  Lines         51277      51279     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       7265       7265          
==========================================
- Hits          36351      36348     -3   
- Misses        13840      13843     +3   
- Partials       1086       1088     +2   

Powered by Codecov. Last update 0bb9561...ab5efef

@oesteban oesteban merged commit 90b0c5a into nipy:master Sep 16, 2016
@effigies effigies deleted the ignore_atime branch September 16, 2016 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants