Skip to content

[ENH] Add a FramewiseDisplacement interface #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 9, 2016

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Sep 8, 2016

Calculates the FD following the implementation of fsl_motion_outliers,
that theoretically follows that of Power et al. 2012.

If save_plot is True, then it will save an FD plot using
seaborn (but this is optional). An example of this FD plot is here:

plot

Includes a test which assesses that this implementation is equivalent
to the one in fsl_motion_outliers

Calculates the FD following the implementation of fsl_motion_outliers,
that theoretically follows that of Power et al. 2012.

If ```save_plot``` is ```True```, then it will save an FD plot using
seaborn (but this is optional).

Includes a test that assess that this implementation is equivalent
to the one in fsl_motion_outliers
@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-0.03%) to 72.235% when pulling 54a6acb on oesteban:enh/FDInterface into 99d191a on nipy:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 72.235% when pulling 54a6acb on oesteban:enh/FDInterface into 99d191a on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 72.235% when pulling 54a6acb on oesteban:enh/FDInterface into 99d191a on nipy:master.

@chrisgorgo
Copy link
Member

It would be great to add option to plot and/or return the values in m/s (speed) instead of mm.

For plotting this could be just another axis (right) labelling.

@oesteban
Copy link
Contributor Author

oesteban commented Sep 8, 2016

If you set normalize=True then the plot is done in mm/s and the legends read correctly. But I can do what you propose.

@chrisgorgo
Copy link
Member

My bad I missed that.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-0.02%) to 72.246% when pulling 98b522c on oesteban:enh/FDInterface into 99d191a on nipy:master.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-0.02%) to 72.245% when pulling ee3676c on oesteban:enh/FDInterface into 99d191a on nipy:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 72.245% when pulling ee3676c on oesteban:enh/FDInterface into 99d191a on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 72.245% when pulling ee3676c on oesteban:enh/FDInterface into 99d191a on nipy:master.

@oesteban oesteban mentioned this pull request Sep 8, 2016
@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage decreased (-0.02%) to 72.245% when pulling 8708bf4 on oesteban:enh/FDInterface into 0f9a620 on nipy:master.

@oesteban
Copy link
Contributor Author

oesteban commented Sep 9, 2016

@satra, @chrisfilo I think this one is ready to go

@chrisgorgo chrisgorgo merged commit 20c40ae into nipy:master Sep 9, 2016
@oesteban oesteban deleted the enh/FDInterface branch September 9, 2016 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants