-
Notifications
You must be signed in to change notification settings - Fork 532
[ENH] Improved PEP8 Compliance for interfaces/fsl #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mgclark, I'm playing around with the docker images running tests in circleCI, that's why your tests are failing here. I'll try to find a solution for this ASAP Sorry about that. |
@oesteban No problem! Thanks! |
Hi @mgclark, could you merge with current master? If you don't have the upstream set, you could do the following in your nipype's git root:
I don't think you will have any conflicts. If so you'll need to fix them, I will assist you with that. Once everything is merged and committed, you just need to do |
@oesteban No conflicts -- thanks! |
Tests are passing -- this should be ready to go now. |
This PR improves the PEP8 compliance of interfaces/fsl and is a partial fix for Issue #597.
The initial PR includes the following:
There are still some long docstring lines; wrapping them made CircleCI unhappy. Even with those outstanding, the readability of the code has been improved.