-
Notifications
You must be signed in to change notification settings - Fork 532
[ENH] Convenient load/save of interface inputs #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
""" | ||
|
||
with open(json_file) as fhandle: | ||
inputs_dict = json.load(fhandle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be sufficient except for checks:
self.inputs.update(**inputs_dict)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, I'm getting object does not have update. (?)
Anyways, I will use sets and get_traitsfree to implement this in a cleaner manner.
Please, do not merge before #1572 . |
This seems like a great addition that a lot of people will appreciate. Could you add a brief mention of it to the documentation and/or use it in an example? |
Sure thing :) |
@chrisfilo : updated documentation here https://github.com/oesteban/nipype/blob/3f2612a46f27964e817d8f52122e88512b3c0d77/doc/users/interface_tutorial.rst |
Added the use of the feature in the ANTs example. |
Ok, let me fix the rendering of the example: https://297-17021985-gh.circle-artifacts.com/0//home/ubuntu/docs/users/examples/smri_ants_registration.html, and some minimal details in the docs: https://297-17021985-gh.circle-artifacts.com/0//home/ubuntu/docs/users/interface_tutorial.html And this is ready to merge then. |
Ok, I have generated them locally and they look good. If they look also fine as circle artifacts, then we are ready to merge. |
Implements #1578