Skip to content

[ENH] Convenient load/save of interface inputs #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 10, 2016

Conversation

oesteban
Copy link
Contributor

Implements #1578

@coveralls
Copy link

coveralls commented Aug 26, 2016

Coverage Status

Coverage increased (+0.02%) to 72.281% when pulling a9feb80 on oesteban:enh/InterfaceLoadSettings into 399f38b on nipy:master.

@coveralls
Copy link

coveralls commented Aug 27, 2016

Coverage Status

Coverage increased (+0.03%) to 72.289% when pulling 48c80b4 on oesteban:enh/InterfaceLoadSettings into 399f38b on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 72.257% when pulling 48c80b4 on oesteban:enh/InterfaceLoadSettings into 399f38b on nipy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 72.257% when pulling 48c80b4 on oesteban:enh/InterfaceLoadSettings into 399f38b on nipy:master.

"""

with open(json_file) as fhandle:
inputs_dict = json.load(fhandle)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may be sufficient except for checks:

self.inputs.update(**inputs_dict)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, I'm getting object does not have update. (?)

Anyways, I will use sets and get_traitsfree to implement this in a cleaner manner.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage decreased (-0.005%) to 72.256% when pulling 7b05e48 on oesteban:enh/InterfaceLoadSettings into b05d153 on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 72.014% when pulling 7b05e48 on oesteban:enh/InterfaceLoadSettings into b05d153 on nipy:master.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage increased (+0.03%) to 72.288% when pulling 775633d on oesteban:enh/InterfaceLoadSettings into b05d153 on nipy:master.

@oesteban
Copy link
Contributor Author

oesteban commented Sep 6, 2016

Please, do not merge before #1572 .

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 72.225% when pulling 701dbc5 on oesteban:enh/InterfaceLoadSettings into 99d191a on nipy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 72.292% when pulling 1788edf on oesteban:enh/InterfaceLoadSettings into 99d191a on nipy:master.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage increased (+0.03%) to 72.292% when pulling 8958e9b on oesteban:enh/InterfaceLoadSettings into 0f9a620 on nipy:master.

@chrisgorgo
Copy link
Member

This seems like a great addition that a lot of people will appreciate. Could you add a brief mention of it to the documentation and/or use it in an example?

@oesteban
Copy link
Contributor Author

oesteban commented Sep 9, 2016

Sure thing :)

@oesteban
Copy link
Contributor Author

oesteban commented Sep 9, 2016

@oesteban
Copy link
Contributor Author

oesteban commented Sep 9, 2016

Added the use of the feature in the ANTs example.

@coveralls
Copy link

coveralls commented Sep 9, 2016

Coverage Status

Coverage increased (+0.03%) to 72.27% when pulling 0d4ea0e on oesteban:enh/InterfaceLoadSettings into 20c40ae on nipy:master.

@oesteban
Copy link
Contributor Author

Ok, let me fix the rendering of the example: https://297-17021985-gh.circle-artifacts.com/0//home/ubuntu/docs/users/examples/smri_ants_registration.html, and some minimal details in the docs: https://297-17021985-gh.circle-artifacts.com/0//home/ubuntu/docs/users/interface_tutorial.html

And this is ready to merge then.

@oesteban
Copy link
Contributor Author

Ok, I have generated them locally and they look good. If they look also fine as circle artifacts, then we are ready to merge.

@coveralls
Copy link

coveralls commented Sep 10, 2016

Coverage Status

Coverage increased (+0.03%) to 72.27% when pulling 4b155b1 on oesteban:enh/InterfaceLoadSettings into 20c40ae on nipy:master.

@satra satra merged commit 10f28fe into nipy:master Sep 10, 2016
oesteban added a commit to oesteban/nipype that referenced this pull request Sep 12, 2016
Found corner cases that failed when calculating the hash of dicts - fixes nipy#1620.

Also found that list of lists of ints do not work in nipy#1591. Fixes also that one.
oesteban added a commit that referenced this pull request Sep 14, 2016
@oesteban oesteban deleted the enh/InterfaceLoadSettings branch February 14, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants