Skip to content

fix: slurm job submission and result checking #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

satra
Copy link
Member

@satra satra commented Aug 16, 2016

No description provided.

@coveralls
Copy link

coveralls commented Aug 16, 2016

Coverage Status

Changes Unknown when pulling 00f07b3 on satra:fix/slurm_variant into * on nipy:master*.

@dalejn
Copy link
Contributor

dalejn commented Aug 19, 2016

Hi Satra,

There's still an issue with jobid_re looking for a string beginning with "Submitted batch job "
Deleting that part of the string in line 41 of slurm.py allows it to run without problems for me

Best,
Dale

@satra
Copy link
Member Author

satra commented Aug 19, 2016

@dalejn - did you add your own custom expression:

wf.run('SLURM', plugin_args={'jobid_re': '([0-9]*)'})

@dalejn
Copy link
Contributor

dalejn commented Aug 19, 2016

Ah, I see-- I didn't.
I've restored your original fixes and included the custom expression, and it runs without any issues

Thanks

@satra satra merged commit 26c72ac into nipy:master Aug 24, 2016
@satra satra removed the in-progress label Aug 24, 2016
@satra satra deleted the fix/slurm_variant branch October 30, 2017 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants