-
Notifications
You must be signed in to change notification settings - Fork 532
ResourceMultiProc plugin and runtime profiler #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… of dying processes
…ad of complete plugin_args dict
Re-basing code with nipype master branch
…e loop in memory_profiler was executing node twice when it didnt finish running the first time
estimated_memory_gb = 1.0 | ||
try: | ||
runtime_threads = float(node['runtime_threads']) | ||
except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KeyError class?
Ok I finished reading the code. Overall this is a great contribution. Apart from the things I mentioned above the resource_sched_profiler should be listed in https://raw.githubusercontent.com/nipy/nipype/master/doc/users/index.rst Sorry for picking on the try-catch-all. Being specific about exception classes will pay off in the future. Silently dealing with all potential exceptions makes debugging incredibly hard (believe me, I learned this the hard way!). |
@dclark87 - one question, is there any reason this information is being kept separate from the provenance record that nipype produces? |
@satra - there is no reason this information is not in the provenance record. We currently store the runtime profiling info in the node's result.runtime as well as the callback logger, but it doesn't hurt to have it in more places. Where is the provenance code? |
…'memory_gb' not specified
generate_gantt_chart('/home/user/run_stats.log', cores=8) | ||
# ...creates gantt chart in '/home/user/run_stats.log.html' | ||
|
||
The `generate_gantt_chart`` function will create an html file that can be viewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ` ?
… into resource_multiproc
LGTM! |
Thanks to @ccraddock for design and debug help