[ENH] Improved AFNI version parsing after recent publication of 16.0.01 #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
added a commit
that referenced
this pull request
Jan 28, 2016
[ENH] Improved AFNI version parsing after recent publication of 16.0.01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1328 only implemented the use case when AFNI was outdated and <16.0.00. This means,
afni_vcheckreturned a version ID derived from the date of compilation. Since 16.0.00 it returns an ID containing the version number.However, with the release of 16.0.01 tonight, I've found that the case of outdated installations with the new format was not correctly processed. This PR fixes that (until they change the version ID format again...)