Skip to content

[MRG] fix: update provenance creation to use released prov library #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 14, 2015

Conversation

satra
Copy link
Member

@satra satra commented Nov 19, 2015

No description provided.

satra added 16 commits November 18, 2015 21:43
…prov

* upstream/pr/1278:
  Removed verbose input (only available in current master of ANTs). Will wait for next release to add.
  Added old class names for backwards compatibility, included DeprecationWarning
  Standardized imports for ANTs
  Finished TODO items in ApplyTransforms and added option to Atropos Added interpolation_parameters, float and verbose to ApplyTransforms and added use_random_seed and verbose to Atropos
  Finished TODO items in resampling (ApplyTransforms)
  PEP8 and other style corrections. Including doctstrings using multi-line string formatting. Changed class names for antsBrainExtraction and antsCorticalThickness.
  Removed redundant _format_xarray from ANTSCommand and replaced other join functions with _format_xarray
…se_current_prov

* origin/fix/use_current_prov:
  fix: changing commit format to support py3
…se_current_prov

* origin/fix/use_current_prov:
  fix: string decoding for prov literal and few pipeline job submission info statements
@satra satra changed the title fix: update provenance creation to use released prov library [MRG] fix: update provenance creation to use released prov library Dec 4, 2015
@satra
Copy link
Member Author

satra commented Dec 4, 2015

@chrisfilo, @bcipolli - this is ready for review

@bcipolli
Copy link

bcipolli commented Dec 4, 2015

@satra is it possible to create a separate pull request for @effigies nibabel deprecation changes? It makes the code review much more challenging to mix the two together.

@effigies
Copy link
Member

effigies commented Dec 4, 2015

Would a rebase resolve it? Because that commit should already be in master.

Edit: It rebased against nipy:master with no --interactive needed.

* upstream/master:
  fix: ensure that T2 file gets used to clean surface
@satra
Copy link
Member Author

satra commented Dec 4, 2015

this should be better, but i was also a little sloppy with the commits and committed a few other things!

@bcipolli
Copy link

bcipolli commented Dec 4, 2015

It's OK--this is way better, much easier to review. Thanks!

@satra
Copy link
Member Author

satra commented Dec 7, 2015

hey folks, any thoughts here. i'd like to merge this as it ensures we have a clean install and operation across systems.

@bcipolli
Copy link

bcipolli commented Dec 7, 2015

Sorry @satra , I don't know the first thing about provenance, nor this package. Downloaded some things to read, but won't be able to get to them until Friday or so..

* upstream/master:
  Correct versions and consistency in install.rst
  fix:import utils needed one more dot
  fix: absolute to relative imports
  add vtk version checking in fsl interfaces
  update CHANGES
  Fix nipy#1218 only, not addressing nipy#973
  force setting ETS_TOOLKIT before tvtk nipy#972
  Created TVTKBaseInterface. Should fix nipy#1218
@satra satra force-pushed the fix/use_current_prov branch from 65304d3 to 526571d Compare December 12, 2015 16:15
chrisgorgo added a commit that referenced this pull request Dec 14, 2015
[MRG] fix: update provenance creation to use released prov library
@chrisgorgo chrisgorgo merged commit 301d394 into nipy:master Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants