Skip to content

Python 3.4 support - fix tests in circleci #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Python 3.4 support - fix tests in circleci #1253

wants to merge 1 commit into from

Conversation

bcipolli
Copy link

#1221 gets us most of the way to Python 3.x support, but some really strange test failures in circleci. We know that nothing there breaks Py2.7 support, so I'm suggesting:

When this PR gets merged, we can then advertise Python 3.x support.

@satra @chrisfilo @alexsavio how does that sound? I'll make y'all collaborators on my repo, so any of us can work on this PR.

@satra
Copy link
Member

satra commented Oct 15, 2015

@bcipolli - could you merge master with this and push - it seems some of the merged updates are still being reflected as changes here.

@bcipolli
Copy link
Author

@satra all done! Woohoo indeed! :)

@alexsavio
Copy link
Contributor

Anything remaining here? Any tip on how to analyse the long circleci output?

@oesteban
Copy link
Contributor

I think this is not necessary anymore, we are testing python 2.7, 3.4 and 3.5 on travis and running all the test workflows in circleci with 2.7 & 3.5. Feel free to reopen if we want to add tests on 3.4 for circle.

@oesteban oesteban closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants