[FIX] Created TVTKBaseInterface. Should fix #1218 #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| have_tvtk = False | ||
|
|
||
| try: | ||
| from tvtk.api import tvtk |
There was a problem hiding this comment.
the problem is that this import results in a sys exit call, if tvtk exists and DISPLAY is unavailable. i couldn't figure out a way to trap it. in that setting it doesn't generate an ImportError. it just plain kills the interpreter.
There was a problem hiding this comment.
Yep. A fix: #1178 (comment)
And a related question: #972 (comment)
|
This might be a better way of doing this: nipype/nipype/interfaces/ants/base.py Line 63 in c31a5a8 |
|
Let's split this discussion :). I move the stuff regarding ETS to #972. Here I will address the problem of @yarikoptic in #1218 only. |
|
@yarikoptic @satra @chrisfilo I think this side of the problem is solved, this is ready to merge. |
Conflicts: CHANGES
Conflicts: CHANGES nipype/algorithms/mesh.py nipype/interfaces/fsl/utils.py
chrisgorgo
added a commit
that referenced
this pull request
Dec 9, 2015
[FIX] Created TVTKBaseInterface. Should fix #1218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.