-
Notifications
You must be signed in to change notification settings - Fork 532
Added support for grabbing and putting data on S3. #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
shariqiqbal2810
commented
Sep 1, 2015
- Added S3DataGrabber to nipype/interfaces/io.py
- Added S3DataSink to nipype/interfaces/io.py
- Added tests to nipype/interfaces/tests/test_io.py
- Currently the S3 tests are using a bucket on our lab's account.
- We would like to have a conversation about a more long-term testing solution.
* Added S3DataGrabber to nipype/interfaces/io.py * Added S3DataSink to nipype/interfaces/io.py * Added tests to nipype/interfaces/tests/test_io.py * Currently the S3 tests are using a bucket on our lab's account.
for testing the grabber you can use the openfmri bucket (which is a public bucket). for the sink, i need to think of a better solution. |
One concern is that these files are large (we were using empty text files before), so the test is slowed considerably.
I changed the s3datagrabber test to use the openfmri data. Unfortunately, these files are fairly large, so the tests are slowed (even though I'm only downloading 2 files). Additionally, these modules require the use of boto3 (AWS Python API), and I was wondering what your solution would be to keep this optional. Currently I have this with my imports
|
FYI the only tests that are failing are due to a lack of boto3 on the testing system. Tests all pass on my system. |
We should skip those tests on systems without boto3 (since not all users On Fri, Sep 4, 2015 at 3:56 AM, Shariq Iqbal notifications@github.com
|
Ok done! Any more thoughts on how to implement the S3DataSink test? |
So I think the only remaining things to sort out are:
|
What about using a fake S3 server? https://github.com/jubos/fake-s3 |
- S3DataGrabber uses anon connection to grab from openfmri bucket - S3DataSink uses fakes3 server to test functionality - Added 'gem install fakes3' to circle.yml
I modified the code to use a fake s3 server on the S3DataSink tests and use an anonymous request on the S3DataGrabber test (in order to avoid needing credentials). I added a 'gem install fakes3' line to the circle.yml file. Hopefully that will be enough to get everything working (It should as long as 'gem' works on the testing server) |
Added support for grabbing and putting data on S3.