Skip to content

ants composite transform is a single file not a list #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2015

Conversation

chrisgorgo
Copy link
Member

No description provided.

@chrisgorgo chrisgorgo changed the title Fix/ants composite ants composite transform is a single file not a list Aug 13, 2015
@satra
Copy link
Member

satra commented Aug 13, 2015

LGTM. @hjmjohnson - any particular reason why composite was a list? if it was a list to support multimodal, this should be refactored for the multimodal PR.

@hjmjohnson
Copy link
Contributor

@satra @chrisfilo

The list was used in order to maintain parity between the various ways that ANTs produces output transforms. If composite transforms are not used, then then the resulting transforms will be a list of file names of the different components.

@hjmjohnson
Copy link
Contributor

@satra @chrisfilo I don't have strong opinions on this. If it is changed, a large commit message should indicate that backwards compatibility will be broken.

I know that I'll need to change (i.e. simplify) some of my pipelines if this is accepted.

Hans

@satra
Copy link
Member

satra commented Aug 14, 2015

@hjmjohnson - this PR is specifically for these two outputs:

composite_transform and inverse_composite_transform

any reason why these would be lists?

@hjmjohnson
Copy link
Contributor

@satra There is only one "ill-conceived, bad" reason to keep them as lists. We should merge this patch set and fix downstream code as necessary to be conformant.

@satra
Copy link
Member

satra commented Aug 15, 2015

@satra There is only one "ill-conceived, bad" reason to keep them as lists

:)

chrisgorgo added a commit that referenced this pull request Aug 16, 2015
ants composite transform is a single file not a list
@chrisgorgo chrisgorgo merged commit 780158a into nipy:master Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants