Skip to content

BUG: Registration interface failed multi-modal #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2015
Merged

BUG: Registration interface failed multi-modal #1176

merged 1 commit into from
Aug 10, 2015

Conversation

hjmjohnson
Copy link
Contributor

Registration interface was failing to support
multimodal input when they are given.

ex)
nipype:
antsWF.inputs.fixed_image=['fixed_t1.nii.gz',
'fixed_t2.nii.gz']
antsWF.inputs.moving_image=['moving_t1.nii.gz',
'moving_t2.nii.gz']

corresponding correct commandline:
--metric MI[
fixed_t1.nii.gz,
moving_t1.nii.gz,\ ...
--metric MI[
fixed_t2.nii.gz,
moving_t2.nii.gz,\ ...

Reported in issue: #1175

Registration interface was failing to support
multimodal input when they are given.

ex)
nipype:
  antsWF.inputs.fixed_image=['fixed_t1.nii.gz',
                             'fixed_t2.nii.gz']
  antsWF.inputs.moving_image=['moving_t1.nii.gz',
                              'moving_t2.nii.gz']

corresponding correct commandline:
  --metric MI[\
      fixed_t1.nii.gz,\
      moving_t1.nii.gz,\ ...
  --metric MI[\
    fixed_t2.nii.gz,\
    moving_t2.nii.gz,\ ...

Reported in issue: #1175
@hjmjohnson
Copy link
Contributor Author

@satra Someone in my lab found a bug in using ANTs in a multi-modal registration. Is it OK to merge this bug fix?

@hjmjohnson hjmjohnson self-assigned this Aug 10, 2015
@hjmjohnson hjmjohnson added the bug label Aug 10, 2015
oesteban added a commit that referenced this pull request Aug 10, 2015
BUG: Registration interface failed multi-modal
@oesteban oesteban merged commit a453b8b into nipy:master Aug 10, 2015
@oesteban
Copy link
Contributor

This looks OK to me. I was wondering, is it possible to use antsRegistration with multichannel images? Because, this is multimodal in the sense that you can create a composite metric that works in different modalities, right?

@satra
Copy link
Member

satra commented Aug 10, 2015

@hjmjohnson - i'm not sure this is doing what you want it to do? it would also be good clarify how one uses it. i think the specs need to be clarified in the docstring and with examples.

for example, the old example1 makes no reference to fixed2 and moving2.

@oesteban
Copy link
Contributor

@satra because it only uses the first modality, isn't it?

@satra
Copy link
Member

satra commented Aug 10, 2015

correct - but that's why we need clear examples of how to do the multimodal stuff. also it seems example 5 should have been:
CC[fixed1, moving1] CC[fixed2.moving2] Mattes[fixed2. moving2]

@oesteban
Copy link
Contributor

Well, @hjmjohnson will correct me, but that example would be monomodal operation... with a level-wise change of the images you try to register. I agree that this behavior is not clearly explained with antsRegistration and we have an opportunity here to make it clearer.

@hjmjohnson hjmjohnson deleted the FixMultiModalAntsRegistration branch August 12, 2015 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants