fix: change how hash values are computed #1174
Conversation
|
@satra Is there a way to use a configuration variable to control which of the two methods is used? Thanks, |
|
@hjmjohnson - this is technically and actually a bug (unless i missed something in my crazy two days of looking over 800+ files). so please do verify that i'm doing the correct thing. being a bug, i would rather not have a config option. essentially, every input spec is converted to a dict and is hashed. the problem was that we were storing the hashed values back in a dict and then hashing the whole thing by converting the dict to a string representation. python doesn't guarantee order of elements in a dict. strictly speaking this is one thing we should even backport to older versions. that being said, you can always run a workflow with |
|
@satra : I forgot about "updatehash=True " That addresses all my concerns, and provides a way to continue using an existing internal cache while updating nipype. I think that "updatehash=True" provides all the functionality needed to prevent years of data re-processing. Hans |
|
@satra : This looks good to me. If I understand correctly, you convert the dict to a list where the elements of the list are sorted versions of the dictionary keys. This approach should give consistent orderings in all cases. |
* upstream/master: (76 commits) Revert "attempt to add coverage" attempt to add coverage run tests in source folder, remove test isolation Don't run TBSS in parallel. less force better memory management fewer subjects updated doctest updated tests make bedpostx test faster match default parameters to those from FSL Various fixed to BEDPOSTX interface - previous version was not operational make eddy correction tests quicker by trimming the volume BUG: Registration interface failed multi-modal lower the requirements of the bedpostx test DTI related fixes. diffusion workflow tests fixes make it more verbose configure location of the test data with env fixed nosetest call ...
* upstream/master: STYLE: Autogenerated files ignored ENH: More end-of-line whitespace removed. ENH: Improve the removal of trailing whitespace updted changelog remove tests added info about composite transforms BUG: Restore registration interface failed multi-modal STYLE: Remove end of line trailing white space fixed doctests fixed syntax there is always only one composite transform - a list is not appropriate here Current ANTS doctests are only valid for unimodal registrations Revert "BUG: Registration interface failed multi-modal" better handling of errors when using caching out dir for epi_reg is compulsory but meaningless for nipype added circleCI and codacy badges fixed dir making adding tests adding further options to 3drefit
* upstream/master: fix: deploy only nipy/nipype master branch fix for identifying if one or multiple durations are employed to describe the condition corrected line of modelgen and added test for variable concatenated events fix test fix: bad copy paste. tst: added more duration checking tests tst: added duration checking fix: use float for computation input fix: update scripts to use single file ants composite_transform output doc: changed description fix: address multimodal and unimodal inputs Update test_auto_MRIConvert.py FIX: add TR, TE and TI flag to FreeSurfer's MRIConvert
fix: change how hash values are computed
@chrisfilo, @hjmjohnson, @oesteban - please review this PR.
while working on the py3 branch, i realized that the way we were calculating the hash values left it up to a random number generator whenever a dict was used. this fixes that. what this does mean is that every current working directory will be rendered invalid.