MRG:Allow extra wait time for Xvfb if needed #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds reasonable. agree that a config option for this would be good. |
|
+1 to any improvement on headless operations :) |
|
Added config option "xvfb_max_wait" |
blakedewey
changed the title
|
@blakedewey - could we also please update the CHANGES file and add the new option to config.rst? |
|
@satra should be good now. I changed the docs in config_file.rst. I hope that is the right one. |
satra
added a commit
that referenced
this pull request
Jul 16, 2015
MRG:Allow extra wait time for Xvfb if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to _redirect_x block to allow more wait time for Xvfb if needed. Max wait time could potentially be set in config. Hard coded for now. @chrisfilo, thoughts?