SLURMGraph plugin #1136
SLURMGraph plugin #1136
Conversation
|
I think the documentation on the "Graph" plugins is a little weak and I always have trouble distinguishing the plugin functions. Maybe this would be a good time to update the docs on these, since we are adding more graph options. |
|
Good point! On Mon, Jul 13, 2015 at 4:14 PM, Blake Dewey notifications@github.com
|
|
What about now? |
| node_status_done = node_completed_status(node) | ||
| ## If a node has no dependencies, and it is requested to run_without_submitting | ||
| ## then run this node in place | ||
| if (not node_status_done) and (len(dependencies[idx]) == 0 ) and (node.run_without_submitting == True): |
There was a problem hiding this comment.
run_without_submitting shouldn't apply to a graph plugin - that option is to ensure nodes can run on the monitoring/submitting node. in the graph plugin case, since the scheduler takes over, this check would be unnecessary. i know this was taken from the SGEgraph code (and i didn't review it closely enough :( ).
|
I cleaned it up and added a small fix to SGEGraph |
|
LGTM |
No description provided.