MRG: Updates to SGE Plugins #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #1128 from blakedewey/master
we use "in" to check and since we are checking an int against a list of strings, we will always get false.
…comes up pending. this avoids calling qstat (and qacct) over and over again when we have alread populated it into the task dictionary.
|
@satra and @hjmjohnson. I have made some updates to the SGE plugin that I think will help streamline qstat and qacct calls. Please look this over and verify. Has been running a few days on my cluster with no problems. @mwaskom this should also help your PEP8 wall of shame. |
|
@hjmjohnson - any chance you can check this? the code changes look fine to me. |
|
@satra I will look at this today. Hans |
|
Job are running use SGE now. I will review succes/failures in the morning. |
|
@satra Last nights testing seemed to perform as expected. I think this is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8 Correction. Typo and function definition cleanup. Hopefully cut down on number of qstat/qacct calls.