Make terminal_output not mandatory (since it has a silent default).

[chrisgorgo]

This will improve the clarity of documentation.

[coveralls]

Coverage decreased (-2.84%) to 67.91% when pulling 49a2134 on chrisfilo:enh/terminal_output into 4bd4ed9 on nipy:master.

[chrisgorgo]

The decreased coveraged is due to this:

$ make specs
Checking specs and autogenerating spec tests
python tools/checkspecs.py
150318-11:57:23,977 workflow DEBUG:
     networkx 1.4 dev or higher detected
ErrorMap has nonautotest
Overlap has nonautotest

[satra]

ah now i remember why the default was essential - we need to ensure that any interface that relies on terminal output (e.g., fslstats) always sets this to stream or file.

it also makes me think that it might be nice for the command line class to have a terminal_output output spec as well (we don't have to make the change here, but would be nice to add during the sprint). that way people can sink those as well. we do capture it in the report (in some cases) and in the prov. so it may not be complete necessary.

otherwise this looks good. can you update the CHANGES?

[chrisgorgo]

On Wed, Mar 18, 2015 at 12:15 PM, Satrajit Ghosh notifications@github.com
wrote:

ah now i remember why the default was essential - we need to ensure that
any interface that relies on terminal output (e.g., fslstats) always sets
this to stream or file.

That could be easily done by overriding this in the InputSpec. Like here:

nipype/nipype/interfaces/afni/preprocess.py

Line 1494 in 732cef3

terminal_output = traits.Enum('allatonce',

it also makes me think that it might be nice for the command line class
to have a terminal_output output spec as well (we don't have to make the
change here, but would be nice to add during the sprint). that way people
can sink those as well. we do capture it in the report (in some cases) and
in the prov. so it may not be complete necessary.

otherwise this looks good. can you update the CHANGES?

Happy to do this, but isn't it too small?

[satra]

no - this is a pseudo API change, so i don't think it hurts to be included. i know practically it doesn't affect anyone really.