Skip to content

fix tbss_non_FA to match FSL's tbss_non_FA command #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 10, 2015
Merged

fix tbss_non_FA to match FSL's tbss_non_FA command #1033

merged 8 commits into from
Feb 10, 2015

Conversation

psharp1289
Copy link
Contributor

Here is the FSL command from their source code:
"${FSLDIR}/bin/tbss_skeleton -i mean_FA -p $thresh mean_FA_skeleton_mask_dst ${FSLDIR}/data/standard/LowerCingulum_1mm all_FA all_${ALTIM}skeletonised -a all$ALTIM"
where all_${ALTIM} in my example is all_RD. notice all_FA is in the placeholder for the 4d Data file under the -p option, and the -a all_RD is there too.
here is what I changed in tbss.py to allow for this:
see new inputnode, all_FA_file and
see (maskgroup, projectfa, [('out_file', 'alt_data_file')]) step in tbss_non_fa.connect command. This is to get the -a option with the all_RD file.

Here is the FSL command from their source code:
"${FSLDIR}/bin/tbss_skeleton -i mean_FA -p $thresh mean_FA_skeleton_mask_dst ${FSLDIR}/data/standard/LowerCingulum_1mm all_FA all_${ALTIM}skeletonised -a all$ALTIM"
where all_${ALTIM} in my example is all_RD. notice all_FA is in the placeholder for the 4d Data file under the -p option, and the -a all_RD is there too.
here is what I changed in tbss.py to allow for this:
see new inputnode, all_FA_file and
see (maskgroup, projectfa, [('out_file', 'alt_data_file')]) step in tbss_non_fa.connect command. This is to get the -a option with the all_RD file.
@satra
Copy link
Member

satra commented Feb 10, 2015

@psharp1289 - could you please merge with upstream and add an updated CHANGES file?

@psharp1289
Copy link
Contributor Author

Sure I will try to do this (again I'm new to GitHub).

Paul

On Tue, Feb 10, 2015 at 12:39 PM, Satrajit Ghosh notifications@github.com
wrote:

@psharp1289 https://github.com/psharp1289 - could you please merge with
upstream and add an updated CHANGES file?


Reply to this email directly or view it on GitHub
#1033 (comment).

Paul B. Sharp
PhD Candidate, University of Illinois Urbana Champaign
http://psharp1289.wix.com/paulbsharp

@psharp1289
Copy link
Contributor Author

I think I did it correctly this time. I went to my local branch called
"patch-1" and update the CHANGES file. Anything else I need to do?

Paul

On Tue, Feb 10, 2015 at 12:39 PM, Satrajit Ghosh notifications@github.com
wrote:

@psharp1289 https://github.com/psharp1289 - could you please merge with
upstream and add an updated CHANGES file?


Reply to this email directly or view it on GitHub
#1033 (comment).

Paul B. Sharp
PhD Candidate, University of Illinois Urbana Champaign
http://psharp1289.wix.com/paulbsharp

@satra
Copy link
Member

satra commented Feb 10, 2015

@psharp1289 - could you copy in the latest CHANGES file (from master) and then add your change, that will help with the merge.

@psharp1289
Copy link
Contributor Author

Ok. My CHANGES file should be identical to the master branch with my addition at the top of the file under "patch-1" branch.

Thanks for the continued assistance.

Paul

satra added a commit that referenced this pull request Feb 10, 2015
fix tbss_non_FA to match FSL's tbss_non_FA command
@satra satra merged commit bfdbacb into nipy:master Feb 10, 2015
@mgxd mgxd mentioned this pull request Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants