Fix bug in Normalize with modulation #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spikefairway - thanks. could you please add an updated CHANGES file? |
| @@ -497,20 +497,24 @@ def _list_outputs(self): | |||
| outputs['normalized_files'] = self.inputs.apply_to_files | |||
| outputs['normalized_source'] = self.inputs.source | |||
| elif 'write' in self.inputs.jobtype: | |||
| if isdefined(self.inputs.write_preserve) and self.inputs.write_preserve: | |||
| prefixNorm = ''.join(['m', self.inputs.out_prefix]) | |||
There was a problem hiding this comment.
one quick question, just to ensure i understand this correctly. so if write_preserve is set, then the output prefix doesn't matter?
There was a problem hiding this comment.
No. Output prefix is fixed such that it corresponds to actual output from SPM (its filename starts 'm') in case that 'write_preserve' is set to True.
|
@satra Sure. I added an updated CHANGES file. Please refer it. |
satra
added a commit
that referenced
this pull request
Jan 20, 2015
Fix bug in Normalize with modulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed bug reported in http://neurostars.org/p/2768/, wrong prefix in case to execute 'Normalize' with modulation.
I'd appreciate it if you could reflect this change.