-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: IO interfaces to JSON files #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b2de969
Added JSON File interface
oesteban 9e33803
Fixed doctest
oesteban f2bef0f
Fixed doctest
oesteban b93734c
Added a JSON file sink
oesteban cb124a4
added auto test file
oesteban 69e09f4
Added undefined value
oesteban 4c8a9fe
Merge branch 'master' into enh/JSONFileInterface
oesteban f59c467
Merge branch 'master' into enh/JSONFileSink
oesteban ac59a94
Merge branch 'enh/JSONFileSink' into enh/JSONFileInterface
oesteban 934f8d0
merge JSON interfaces
oesteban cb17ee6
execute make specs and make check-before-commit
oesteban fe6a054
add forgotten CHANGES
oesteban c525a1b
add dict input to JSONFileSink #1020
oesteban dd31756
Merge branch 'master' into enh/JSONFileInterface
oesteban 273fec0
Merge branch 'master' into enh/JSONFileInterface
oesteban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# AUTO-GENERATED by tools/checkspecs.py - DO NOT EDIT | ||
from nipype.testing import assert_equal | ||
from nipype.interfaces.io import JSONFileGrabber | ||
|
||
def test_JSONFileGrabber_inputs(): | ||
input_map = dict(ignore_exception=dict(nohash=True, | ||
usedefault=True, | ||
), | ||
in_file=dict(mandatory=True, | ||
), | ||
) | ||
inputs = JSONFileGrabber.input_spec() | ||
|
||
for key, metadata in input_map.items(): | ||
for metakey, value in metadata.items(): | ||
yield assert_equal, getattr(inputs.traits()[key], metakey), value | ||
|
||
def test_JSONFileGrabber_outputs(): | ||
output_map = dict() | ||
outputs = JSONFileGrabber.output_spec() | ||
|
||
for key, metadata in output_map.items(): | ||
for metakey, value in metadata.items(): | ||
yield assert_equal, getattr(outputs.traits()[key], metakey), value | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# AUTO-GENERATED by tools/checkspecs.py - DO NOT EDIT | ||
from nipype.testing import assert_equal | ||
from nipype.interfaces.io import JSONFileSink | ||
|
||
def test_JSONFileSink_inputs(): | ||
input_map = dict(ignore_exception=dict(nohash=True, | ||
usedefault=True, | ||
), | ||
out_file=dict(), | ||
) | ||
inputs = JSONFileSink.input_spec() | ||
|
||
for key, metadata in input_map.items(): | ||
for metakey, value in metadata.items(): | ||
yield assert_equal, getattr(inputs.traits()[key], metakey), value | ||
|
||
def test_JSONFileSink_outputs(): | ||
output_map = dict(out_file=dict(), | ||
) | ||
outputs = JSONFileSink.output_spec() | ||
|
||
for key, metadata in output_map.items(): | ||
for metakey, value in metadata.items(): | ||
yield assert_equal, getattr(outputs.traits()[key], metakey), value | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"param2": 4, "param1": "exampleStr"} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about adding an input that accepts a dictionary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @satra, I don't understand what you mean :S.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like
in_dict = Dict(desc='input JSON dictionary')
so that you can pass a dictionary output of another node directly into the jsonsink node? and it will populate the relevant fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see 👍