-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: antsIntroduction handles RA and RI transformations #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
when generating the _list_outputs if -t RA or -t RI is set, *_warp_field outputs will not be required
transmodel = self.inputs.transformation_model | ||
|
||
# When transform is set as 'RI'/'RA', no wrap fields will be outputed | ||
if transmodel not in ['RI', 'RA']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if isdefined(transmodel) and transmodel not in [...]
this would check against the possibility that a user undefines that field.
transmodel = self.inputs.transformation_model | ||
|
||
# When transform is set as 'RI'/'RA', no wrap fields will be outputed | ||
if isdefined(transmodel) and transmodel not in ['RI', 'RA']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if someone unsets/undefines this, what will antsIntroduction do? do you know what the ants default behavior is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @satra, thanks for reviewing. I just double-checked, if transmodel is undefined, antsIntroduction will set '-t GR' which is 'greedy SyN' by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsqshr - in that case the if statement should perhaps be:
if not isdefined(transmodel) or (isdefined(transmodel) and transmodel not in ['RI', 'RA']):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satra Thx for pointing out. You are right about it. I just made the according change and locally tested it with real nii images.
…oduction_optional_outputs
ENH: antsIntroduction handles RA and RI transformations
when generating the _list_outputs if -t RA or -t RI is set, *_warp_field
outputs will not be required