Skip to content

ENH: antsIntroduction handles RA and RI transformations #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2015

Conversation

lsqshr
Copy link
Contributor

@lsqshr lsqshr commented Dec 8, 2014

when generating the _list_outputs if -t RA or -t RI is set, *_warp_field
outputs will not be required

when generating the _list_outputs if -t RA or -t RI is set, *_warp_field
outputs will not be required
transmodel = self.inputs.transformation_model

# When transform is set as 'RI'/'RA', no wrap fields will be outputed
if transmodel not in ['RI', 'RA']:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if isdefined(transmodel) and transmodel not in [...]

this would check against the possibility that a user undefines that field.

@lsqshr lsqshr changed the title antsIntroduction handles RA and RI transformations ENH: antsIntroduction handles RA and RI transformations Jan 10, 2015
transmodel = self.inputs.transformation_model

# When transform is set as 'RI'/'RA', no wrap fields will be outputed
if isdefined(transmodel) and transmodel not in ['RI', 'RA']:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if someone unsets/undefines this, what will antsIntroduction do? do you know what the ants default behavior is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @satra, thanks for reviewing. I just double-checked, if transmodel is undefined, antsIntroduction will set '-t GR' which is 'greedy SyN' by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsqshr - in that case the if statement should perhaps be:

if not isdefined(transmodel) or (isdefined(transmodel) and transmodel not in ['RI', 'RA']):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satra Thx for pointing out. You are right about it. I just made the according change and locally tested it with real nii images.

satra added a commit that referenced this pull request Jan 20, 2015
ENH: antsIntroduction handles RA and RI transformations
@satra satra merged commit 9fcef7c into nipy:master Jan 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants