Skip to content

Update to 1.0.1-dev broke master #2411

Closed
@oesteban

Description

@oesteban

Seems like building docs fails for one workflow (nipype/workflows/smri/ants/ANTSBuildTemplate.py).

Apparently, the ignore_exception input should be dropped in favor of the new class attribute in interfaces. Before 1.0.0, nipype would only show a warning, but now after the version bump to 1.0.1-dev it raises an error (#2403).

We need to fix a couple of things:

  • Make sure no legacy code remains setting interface.inputs.ignore_exception
  • Make sure interfaces no longer support ignore_exception and terminal_output as inputs. In particular, double check with the Function interface.

https://circleci.com/gh/nipy/nipype/3178
https://circleci.com/gh/nipy/nipype/3176
https://circleci.com/gh/nipy/nipype/3172

Exception occurred in traits notification handler.
Please check the log file for details.
Exception occurred in traits notification handler for object: 
AffineTransformList = <undefined>
function_str = def MakeListsOfTransformLists(warpTransformList, AffineTransformList):
    return list(map(list, list(zip(warpTransformList, AffineTransformList))))

ignore_exception = True
warpTransformList = <undefined>
, trait: ignore_exception, old value: False, new value: True
Traceback (most recent call last):
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 519, in _dispatch_change_event
    self.dispatch( handler, *args )
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 482, in dispatch
    handler( *args )
  File "/src/nipype/nipype/interfaces/base/specs.py", line 140, in _deprecated_warn
    raise TraitError(msg)
traits.trait_errors.TraitError: Input ignore_exception in interface Function is deprecated. Will be removed or raise an error as of release 1.0.0 

180126-21:20:31,898 traits ERROR:
	 Exception occurred in traits notification handler for object: 
AffineTransformList = <undefined>
function_str = def MakeListsOfTransformLists(warpTransformList, AffineTransformList):
    return list(map(list, list(zip(warpTransformList, AffineTransformList))))

ignore_exception = True
warpTransformList = <undefined>
, trait: ignore_exception, old value: False, new value: True
Traceback (most recent call last):
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 519, in _dispatch_change_event
    self.dispatch( handler, *args )
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 482, in dispatch
    handler( *args )
  File "/src/nipype/nipype/interfaces/base/specs.py", line 140, in _deprecated_warn
    raise TraitError(msg)

traits.trait_errors.TraitError: Input ignore_exception in interface Function is deprecated. Will be removed or raise an error as of release 1.0.0 
Exception occurred in traits notification handler for object: 
averageAffineTranform = <undefined>
function_str = def MakeTransformListWithGradientWarps(averageAffineTranform,
                                       gradientStepWarp):
    return [
        averageAffineTranform, gradientStepWarp, gradientStepWarp,
        gradientStepWarp, gradientStepWarp
    ]

gradientStepWarp = <undefined>
ignore_exception = True
, trait: ignore_exception, old value: False, new value: True
Traceback (most recent call last):
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 519, in_dispatch_change_event
    self.dispatch( handler, *args )
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 482, in dispatch
    handler( *args )
  File "/src/nipype/nipype/interfaces/base/specs.py", line 140, in _deprecated_warn
    raise TraitError(msg)
traits.trait_errors.TraitError: Input ignore_exception in interface Function is deprecated. Will be removed or raise an error as of release 1.0.0 

180126-21:20:31,924 traits ERROR:
	 Exception occurred in traits notification handler for object: 
averageAffineTranform = <undefined>
function_str = def MakeTransformListWithGradientWarps(averageAffineTranform,
                                       gradientStepWarp):
    return [
        averageAffineTranform, gradientStepWarp, gradientStepWarp,
        gradientStepWarp, gradientStepWarp
    ]

gradientStepWarp = <undefined>
ignore_exception = True
, trait: ignore_exception, old value: False, new value: True
Traceback (most recent call last):
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 519, in _dispatch_change_event
    self.dispatch( handler, *args )
  File "/opt/conda/envs/neuro/lib/python3.6/site-packages/traits/trait_notifiers.py", line 482, in dispatch
    handler( *args )
  File "/src/nipype/nipype/interfaces/base/specs.py", line 140, in _deprecated_warn
    raise TraitError(msg)

traits.trait_errors.TraitError: Input ignore_exception in interface Function is deprecated. Will be removed or raise an error as of release 1.0.0 

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions