STY: Further simplification

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

nipype/pipeline/engine/utils.py

@@ -1490,9 +1490,7 @@ def clean_working_directory(
     else:
         if not str2bool(config["execution"]["keep_inputs"]):
             input_files = []
-            inputdict = inputs.trait_get()
-            input_files.extend(walk_outputs(inputdict))
-            input_files = [path for path, type in input_files if type == "f"]
+            input_files = {path for path, type in walk_outputs(inputs.trait_get()) if type == "f"}
             files2remove.extend(
                 f for f in walk_files(cwd) if f in input_files and f not in needed_files
             )

nipype/utils/filemanip.py

@@ -715,13 +715,11 @@ def write_rst_header(header, level=0):
 
 
 def write_rst_list(items, prefix=""):
-    out = [f"{prefix} {item}" for item in ensure_list(items)]
-    return "\n".join(out) + "\n\n"
+    return "\n".join(f"{prefix} {item}" for item in ensure_list(items)) + "\n\n"
 
 
 def write_rst_dict(info, prefix=""):
-    out = [f"{prefix}* {key} : {value}" for key, value in sorted(info.items())]
-    return "\n".join(out) + "\n\n"
+    return "\n".join(f"{prefix}* {k} : {v}" for k, v in sorted(info.items())) + "\n\n"
 
 
 def dist_is_editable(dist):

nipype/utils/nipype2boutiques.py

@@ -477,7 +477,7 @@ def get_boutiques_output(outputs, name, spec, interface, tool_inputs):
             # If extensions all the same, set path template as
             # wildcard + extension. Otherwise just use a wildcard
             if len(extensions) == 1:
-                output["path-template"] = "*" + extensions[0]
+                output["path-template"] = "*" + extensions.pop()
             else:
                 output["path-template"] = "*"
             return output