Skip to content

Pre-release book-keeping #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2017
Merged

Pre-release book-keeping #541

merged 3 commits into from
Jun 15, 2017

Conversation

effigies
Copy link
Member

#540 prompted me to follow up on #515 and get the docs up-to-date.

I also hope to see a new release soon. Let me know if there's anything else I can do to help it along.

If at all possible, I think #526 would be great to have in before the release.

@effigies
Copy link
Member Author

@pauldmccarthy Let me know if you prefer to be credited with another version of your name.

@fepegar Just want to verify that I got your name correct. Based on a StackOverflow profile with the same username, I believe this is you?

@R3DDY97 Do you have a name/alias you'd prefer to be credited as?

@fepegar
Copy link
Contributor

fepegar commented Jun 13, 2017

Hi @effigies
Yes, that's me. Thank you!

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         177      177           
  Lines       24300    24300           
  Branches     2608     2608           
=======================================
  Hits        22906    22906           
  Misses        919      919           
  Partials      475      475

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e058598...49a726b. Read the comment docs.

@pauldmccarthy
Copy link
Contributor

Hi @effigies, looks great - thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.218% when pulling f3f6c8a on changelog into e058598 on master.

@R3DDY97
Copy link
Contributor

R3DDY97 commented Jun 13, 2017

Hi @effigies
i would prefer to be credited as Dr.VenkyReddy
Thanks

@effigies
Copy link
Member Author

@R3DDY97 Given that we haven't included "Dr." for any of the other authors with doctorates, thus far, I've added you as "Venky Reddy". I hope this is acceptable.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.218% when pulling 49a726b on changelog into e058598 on master.

@R3DDY97
Copy link
Contributor

R3DDY97 commented Jun 15, 2017

@effigies
Yeah That's OK fine ..

btw mine is not Doctorate's Dr (PhD)
Its Physician Dr. got after medical Graduation..

@effigies effigies requested a review from matthew-brett June 15, 2017 13:28
Copy link
Member

@matthew-brett matthew-brett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks.

@matthew-brett matthew-brett merged commit acfd925 into master Jun 15, 2017
@effigies effigies deleted the changelog branch June 15, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants