RF+TST: allow dtype specifiers as fileslice input #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fileslice function previously insisted on np.dtype object as dtype specifier. Allow any dtype specifier.
Current coverage is 93.97% (diff: 100%)@@ master #485 diff @@
==========================================
Files 166 166
Lines 21828 21836 +8
Methods 0 0
Messages 0 0
Branches 2326 2327 +1
==========================================
+ Hits 20512 20520 +8
Misses 885 885
Partials 431 431
|
|
LGTM. |
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fileslice function previously insisted on np.dtype object as dtype
specifier. Allow any dtype specifier.