Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve CI failures #1413

Merged
merged 4 commits into from
Mar 18, 2025
Merged

chore: Resolve CI failures #1413

merged 4 commits into from
Mar 18, 2025

Conversation

effigies
Copy link
Member

  • setuptools has started pulling non-public APIs from distutils, breaking the py39-min tests. The simplest solution is to require numpy >=1.23, which deprecated numpy.distutils and removed it from any import tree we use.
  • Ruff has started auto-fixing return types that could be Self. I would like to remove the typing_extensions dependency, but this does not introduce it.
  • Either mypy or numpy made some modification that requires us to better type something that expects an integer type or an integer dtype. Easy enough.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (84294f4) to head (6948625).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1413   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         208      209    +1     
  Lines       29772    29777    +5     
  Branches     3355     3357    +2     
=======================================
+ Hits        28385    28390    +5     
  Misses        948      948           
  Partials      439      439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies merged commit db4c859 into nipy:master Mar 18, 2025
42 checks passed
@effigies effigies deleted the mnt/updates branch March 18, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant