Skip to content

RF: Fix ast library type and attribute deprecation warnings #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
effigies merged 1 commit into from
Jun 27, 2024
Merged

RF: Fix ast library type and attribute deprecation warnings #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions nibabel/nicom/ascconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def assign2atoms(assign_ast, default_class=int):
prev_target_type = OrderedDict
elif isinstance(target, ast.Subscript):
if isinstance(target.slice, ast.Constant): # PY39
index = target.slice.n
index = target.slice.value
else: # PY38
index = target.slice.value.n
atoms.append(Atom(target, prev_target_type, index))
Expand Down Expand Up @@ -174,12 +174,10 @@ def obj_from_atoms(atoms, namespace):

def _get_value(assign):
value = assign.value
if isinstance(value, ast.Num):
return value.n
if isinstance(value, ast.Str):
return value.s
if isinstance(value, ast.Constant):
return value.value
if isinstance(value, ast.UnaryOp) and isinstance(value.op, ast.USub):
return -value.operand.n
return -value.operand.value
raise AscconvParseError(f'Unexpected RHS of assignment: {value}')


Expand Down