Skip to content

RF: Prefer using np.vstack instead of np.row_stack #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

RF: Prefer using np.vstack instead of np.row_stack #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nibabel/brikhead.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def get_affine(self):
# AFNI default is RAI- == LPS+ == DICOM order. We need to flip RA sign
# to align with nibabel RAS+ system
affine = np.asarray(self.info['IJK_TO_DICOM_REAL']).reshape(3, 4)
affine = np.row_stack((affine * [[-1], [-1], [1]], [0, 0, 0, 1]))
affine = np.vstack((affine * [[-1], [-1], [1]], [0, 0, 0, 1]))
return affine

def get_data_scaling(self):
Expand Down
2 changes: 1 addition & 1 deletion nibabel/ecat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def read_mlist(fileobj, endianness):
mlist_index += n_rows
if mlist_block_no <= 2: # should block_no in (1, 2) be an error?
break
return np.row_stack(mlists)
return np.vstack(mlists)


def get_frame_order(mlist):
Expand Down