Skip to content

Conversation

@effigies
Copy link
Member

@effigies effigies commented Dec 3, 2023

Small cleanup. When running the test suite, simple.nc gets dropped into the working directory by the netcdf doctests. This detects a doctest in the externals directory and chdirs into a temporary directory to guard us against these, as we'd rather not modify the vendored files more than necessary.

@codecov
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ba501e) 92.24% compared to head (33c21d4) 92.24%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1279   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          99       99           
  Lines       12452    12452           
  Branches     2560     2560           
=======================================
  Hits        11486    11486           
  Misses        643      643           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies mentioned this pull request Dec 3, 2023
15 tasks
@effigies effigies merged commit 07289b7 into nipy:master Dec 6, 2023
@effigies effigies deleted the test/chdir-externals branch December 6, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant