Skip to content

FIX: Catch random bad slice when testing image slicing #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

FIX: Catch random bad slice when testing image slicing #1221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions nibabel/tests/test_spatialimages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,15 +540,15 @@ def test_slicer(self):
sliceobj = tuple(np.random.choice(slice_elems, n_elems))
try:
sliced_img = img.slicer[sliceobj]
except (IndexError, ValueError):
# Only checking valid slices
pass
else:
sliced_data = in_data[sliceobj]
assert (sliced_data == sliced_img.get_fdata()).all()
assert (sliced_data == sliced_img.dataobj).all()
assert (sliced_data == img.dataobj[sliceobj]).all()
assert (sliced_data == img.get_fdata()[sliceobj]).all()
except (IndexError, ValueError, HeaderDataError):
# Skip invalid slices or images that can't be created
continue

sliced_data = in_data[sliceobj]
assert np.array_equal(sliced_data, sliced_img.get_fdata())
assert np.array_equal(sliced_data, sliced_img.dataobj)
assert np.array_equal(sliced_data, img.dataobj[sliceobj])
assert np.array_equal(sliced_data, img.get_fdata()[sliceobj])


class MmapImageMixin:
Expand Down