Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make imagestats module available on import nibabel #1208

Merged
merged 2 commits into from
Feb 28, 2023
Merged

ENH: Make imagestats module available on import nibabel #1208

merged 2 commits into from
Feb 28, 2023

Conversation

Factral
Copy link
Contributor

@Factral Factral commented Feb 27, 2023

this add the import of imagestats to init.py

context of imagestats: #952

Solve #1207

@effigies
Copy link
Member

Thanks! Can you run isort on it? We also have pre-commit configured, so you can pre-commit install and pre-commit run --all.

@Factral
Copy link
Contributor Author

Factral commented Feb 27, 2023

I already run pre-commit but I'm getting this error, any idea why? I did not touch any other file or configuration

image

@effigies
Copy link
Member

Ah, for the mypy one, you need to run hatch build --hooks-only. Or simpler pip install -e ..

@Factral
Copy link
Contributor Author

Factral commented Feb 27, 2023

Ah, for the mypy one, you need to run hatch build --hooks-only. Or simpler pip install -e ..

thanks!, the error was because i was trying to commit from windows 😂

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 92.15% // Head: 92.04% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (0427e14) compared to base (b8b57cc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   92.15%   92.04%   -0.12%     
==========================================
  Files          97       97              
  Lines       12334    12334              
  Branches     2534     2534              
==========================================
- Hits        11367    11353      -14     
- Misses        645      654       +9     
- Partials      322      327       +5     
Impacted Files Coverage Δ
nibabel/__init__.py 100.00% <100.00%> (ø)
nibabel/environment.py 75.00% <0.00%> (-20.00%) ⬇️
nibabel/streamlines/tck.py 97.44% <0.00%> (-1.03%) ⬇️
nibabel/casting.py 85.53% <0.00%> (-0.86%) ⬇️
nibabel/viewers.py 95.49% <0.00%> (-0.65%) ⬇️
nibabel/dft.py 85.45% <0.00%> (-0.61%) ⬇️
nibabel/nifti1.py 92.49% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies changed the title NF added import imagestats ENH: Make imagestats module available on import nibabel Feb 27, 2023
@effigies
Copy link
Member

Thanks! The failures are #1209, so unrelated to this.

@effigies effigies merged commit 3a4cc5e into nipy:master Feb 28, 2023
@effigies effigies added this to the 5.1.0 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants