Tests: failure of `nisext.tests.test_doctest_markup.test_byter` with Python 3.5

[FRidh]

The test nisext.tests.test_doctest_markup.test_byter fails with nibabel 2.0.1. Only fails with Python 3.5 only.

http://hydra.nixos.org/build/27003289/nixlog/1/raw

[bcipolli]

@FRidh could you check if this is solved by #363 ?

[FRidh]

Unfortunately not.

======================================================================
ERROR: nisext.tests.test_doctest_markup.test_byter
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/iqq89s0zzgg8sn7s6nfnsw211rnf86yf-python3.5-nose-1.3.4/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/nix/store/r6nfwyyi4sn6vmq7zzja6sfhcga9n8g4-python3.5-numpy-1.10.1/lib/python3.5/site-packages/numpy/testing/decorators.py", line 146, in skipper_func
    return f(*args, **kwargs)
  File "/home/freddy/Code/nibabel/nisext/tests/test_doctest_markup.py", line 161, in test_byter
    byter(line),
  File "/home/freddy/Code/nibabel/nisext/py3builder.py", line 238, in byter
    return codegen.to_source(tree)
  File "/home/freddy/Code/nibabel/nisext/codegen.py", line 37, in to_source
    generator.visit(node)
  File "/home/freddy/Code/nibabel/nisext/ast.py", line 319, in visit
    return self.generic_visit(node)
  File "/home/freddy/Code/nibabel/nisext/ast.py", line 327, in generic_visit
    self.visit(item)
  File "/home/freddy/Code/nibabel/nisext/ast.py", line 318, in visit
    return f(node)
  File "/home/freddy/Code/nibabel/nisext/codegen.py", line 119, in visit_Assign
    self.visit(node.value)
  File "/home/freddy/Code/nibabel/nisext/ast.py", line 318, in visit
    return f(node)
  File "/home/freddy/Code/nibabel/nisext/codegen.py", line 342, in visit_Call
    if node.starargs is not None:
AttributeError: 'Call' object has no attribute 'starargs'

----------------------------------------------------------------------
Ran 7071 tests in 215.419s

FAILED (SKIP=70, errors=1)

I tested nibabel 7dfc9d9 and with nixpkgs f084bd55827a9ddafc965d1cd972f437dbe9f235

[effigies]

Can you try f1bcfcb?

[effigies]

@FRidh Try 33bbe11 (or better yet, effigies/issue-366).

Edit: Make that 7a71e5a. Failed to squash commits.

[FRidh]

Still fails with your branch.

On Wed, Oct 28, 2015 at 10:18 PM, Chris Markiewicz <notifications@github.com

wrote:

@FRidh https://github.com/FRidh Try 33bbe11
33bbe11
(or better yet, effigies/issue-366).

—
Reply to this email directly or view it on GitHub
#366 (comment).

[effigies]

That's because I put the check in the wrong function. Try now (883c771).

[matthew-brett]

I wonder whether we should just drop this stuff now - we aren't using it, it's only useful for Python 2.5.

[FRidh]

That fixed it. Thanks.

[effigies]

Travis hasn't tested for 2.5 in 2.5 years, and there's plenty of dependence on 2.6+ features, so anybody using nibabel with Python 2.5 is already using an old version.

+1 for dropping 2.5 support in master.

[matthew-brett]

We don't support 2.5, but I left the testing machinery in there in case anyone else was using it to support Python 2.5. I guess probably not...

[matthew-brett]

#369

[effigies]

Issue obviated by #369.