Do not create README if there is other allowed README.md or alike #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
reviewed
Mar 17, 2025
heudiconv/bids.py
Outdated
| @@ -196,6 +196,8 @@ def populate_bids_templates( | |||
| op.join(path, "README"), | |||
| "TODO: Provide description for the dataset -- basic details about the " | |||
| "study, possibly pointing to pre-registration (if public or embargoed)", | |||
| # TODO: get from schema | |||
| glob_suffixes=[".md", ".txt", ".rst"], | |||
There was a problem hiding this comment.
Shouldn't you also add the empty string as a possible suffix?
There was a problem hiding this comment.
d'oh, right -- there could be indeed a suffix less match, good catch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 82.48% 82.55% +0.06%
==========================================
Files 42 42
Lines 4323 4340 +17
==========================================
+ Hits 3566 3583 +17
Misses 757 757 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.