Skip to content

Fixup testing: kludge for pydicom 3.0.0 in dcmstack, ignore some warnings from nipype for python 3.12 #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fixup testing: kludge for pydicom 3.0.0 in dcmstack, ignore some warnings from nipype for python 3.12 #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc191af
Ignore 3.12 warning on utcnow in nipype
yarikoptic Sep 13, 2024
bf793c9
BF(workaround): add kludge for read_file for dcmstack
yarikoptic Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions heudiconv/dicoms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
# suppress warning
import nibabel.nicom.dicomwrappers as dw

# TODO: remove the kludge whenever
# https://github.com/moloney/dcmstack/pull/90 is merged and released
if not hasattr(dcm, "read_file"):
dcm.read_file = dcm.dcmread

lgr = logging.getLogger(__name__)
total_files = 0
# Might be monkey patched by user heuristic to tune desired compression level.
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ filterwarnings =
ignore:.*pkg_resources:DeprecationWarning
# <https://github.com/nipy/nipype/issues/3563>
ignore:.*Use setlocale.* instead:DeprecationWarning:nipype
# <https://github.com/nipy/nipype/pull/3670>
ignore:.*datetime.datetime.utcnow\(\) is deprecated.*:DeprecationWarning:nipype

[coverage:run]
include = heudiconv/*
Expand Down