Fix inconsistent behavior of existing session when using -d compared to --files option: raise an AssertionError instead of just a warning #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to --files option
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 81.94% 82.00% +0.06%
==========================================
Files 41 41
Lines 4132 4130 -2
==========================================
+ Hits 3386 3387 +1
+ Misses 746 743 -3
☔ View full report in Codecov by Sentry. |
This was referenced Jun 7, 2023
Open
yarikoptic
reviewed
Jun 9, 2023
| if grouping != "all": | ||
| assert (study_session_info not in study_sessions), ( | ||
| f"Existing study session {study_session_info} " | ||
| f"already in analyzed sessions {study_sessions.keys()}") |
There was a problem hiding this comment.
I have checked 1366 heudiconv.log files from conversions and found none with "Existing study session with the same values". So I think at least I should be safe ;) let's see how error treats us.
yarikoptic
changed the title
|
change of behavior so adding |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is described in #683