Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .subsecond optional in BIDS/DICOM datetime entries #675

Merged
merged 2 commits into from
May 23, 2023

Conversation

yarikoptic
Copy link
Member

I think overall it closes #657 and should address the issue reported on https://neurostars.org/t/heudiconv-time-format-error/25806

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (4383fea) 81.88% compared to head (b810958) 81.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   81.88%   81.94%   +0.06%     
==========================================
  Files          41       41              
  Lines        4117     4132      +15     
==========================================
+ Hits         3371     3386      +15     
  Misses        746      746              
Impacted Files Coverage Δ
heudiconv/bids.py 90.40% <100.00%> (-0.03%) ⬇️
heudiconv/dicoms.py 85.47% <100.00%> (ø)
heudiconv/tests/test_utils.py 100.00% <100.00%> (ø)
heudiconv/utils.py 91.81% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels May 23, 2023
@yarikoptic yarikoptic merged commit e3c53b8 into nipy:master May 23, 2023
@github-actions
Copy link

🚀 PR was released in v0.13.1 🚀

@yarikoptic yarikoptic deleted the bf-strptime-subsecond branch December 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heudiconv failure with false report of successful conversion
2 participants