bids_ME heuristic: add test for the dataset that raised #541, add support for MEGRE #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In `test_ME_mag_phase_conversion`
|
Yes, please, @yarikoptic; add MEGRE to datalad. Then I will correct the tests. |
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 81.21% 81.24% +0.03%
==========================================
Files 41 41
Lines 3784 3813 +29
==========================================
+ Hits 3073 3098 +25
- Misses 711 715 +4
Continue to review full report at Codecov.
|
yarikoptic
requested changes
Mar 29, 2022
| for s in seqinfo: | ||
| if '_ME_' in s.series_description: | ||
| info[bold].append(s.series_id) | ||
| if 'GRE_QSM' in s.series_description: | ||
| if s.image_type[2] == 'M': |
There was a problem hiding this comment.
note: this code block is not covered by tests... what data was supposed to have it covered?
| try: | ||
| datadir = fetch_data(tmppath, "dicoms/velasco/{subID}") | ||
| except IncompleteResultsError as exc: | ||
| pytest.skip("Failed to fetch test data: %s" % str(exc)) |
There was a problem hiding this comment.
note -- this line is "covered" which means that the test just skipped... I think I might see the reason
yarikoptic
added a commit
to datalad/datasets.datalad.org
that referenced
this pull request
Mar 31, 2022
yarikoptic
added a commit
to datalad/datasets.datalad.org
that referenced
this pull request
Mar 31, 2022
|
coolio, thank you @pvelasco ! |
yarikoptic
changed the title
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.