RF+ENH: provide bids schema driven support for manipulation of bids filenames #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2022
This would open for a better structuring of BIDS support code etc. All bids.utils are imported within bids/__init__.py so there should be no effect on imports from heudiconv.bids
ATM we will need only these two files to establish consistent order of the entities in the filenames. Later we might want to carry a more complete copy of the schema, or may be eventually some proper bidsschema python package would appear to provide desired functionality anyways
=== Do not change lines below ===
{
"chain": [],
"cmd": "python3 -m isort -m3 --fgw 2 --tc {outputs}",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [
"heudiconv/bids/*py",
"heudiconv/bids/tests/*py"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 81.21% 81.39% +0.18%
==========================================
Files 41 45 +4
Lines 3784 3817 +33
==========================================
+ Hits 3073 3107 +34
+ Misses 711 710 -1
Continue to review full report at Codecov.
|
This was referenced Apr 4, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452
A plan (somewhat):