Skip to content

Empty acq_time results in empty cell not 'n/a' #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Empty acq_time results in empty cell not 'n/a' #390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4895d4b
Empty acq_time results in empty cell not 'n/a'
Aksoo Oct 28, 2019
067c99c
Use empty string not None
Aksoo Oct 28, 2019
8f0f767
need str typecast
Aksoo Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion heudiconv/bids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def get_formatted_scans_key_row(dcm_fn):
acq_time = datetime.strptime(td, '%H%M%S%Y%m%d').isoformat()
except (AttributeError, ValueError) as exc:
lgr.warning("Failed to get date/time for the content: %s", str(exc))
acq_time = None
acq_time = ''
# add random string
# But let's make it reproducible by using all UIDs
# (might change across versions?)
Expand Down