Skip to content

ENH: Add kwargs in Brain.add_* and pass it to mayavi modules #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Nov 1, 2019
Merged

ENH: Add kwargs in Brain.add_* and pass it to mayavi modules #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4399524
Feat: add kwargs in Brain.add_* and pass it to mayavi modules, so tha…
DingkunLiu Oct 3, 2019
d86b19f
Fix: Fix code styles which failed in the flake test.
DingkunLiu Oct 3, 2019
8cd93f3
Modify test_viz to pass the kwargs to the mayavi module.
DingkunLiu Oct 3, 2019
9d077da
fix flake test.
DingkunLiu Oct 3, 2019
c7a5912
Specifying `kwargs` as `mlab_kws` and make the documentation more clear.
DingkunLiu Oct 16, 2019
c3c8602
Revert "Specifying `kwargs` as `mlab_kws` and make the documentation …
DingkunLiu Oct 18, 2019
2c86a04
Link mayavi documents.
DingkunLiu Oct 18, 2019
7264ec5
Give detailed explanations about the kwargs passed to the functions.
DingkunLiu Oct 18, 2019
b746e0f
Revert "Link mayavi documents."
DingkunLiu Oct 18, 2019
0a6e0fa
Change the position of line breaking.
DingkunLiu Oct 18, 2019
9f95d24
Fix the typo and unavailable links.
DingkunLiu Oct 30, 2019
ac0b7b8
Fix render errors.
DingkunLiu Oct 31, 2019
0d5cdbf
Revert "Fix render errors."
DingkunLiu Oct 31, 2019
bbf7631
Fix render error.
DingkunLiu Oct 31, 2019
35654e8
Improve code rendering.
DingkunLiu Oct 31, 2019
e3c6ee7
Revert "Fix render error."
DingkunLiu Oct 31, 2019
6efccac
Fix line breaking error.
DingkunLiu Oct 31, 2019
533bab5
Revert "Fix line breaking error."
DingkunLiu Oct 31, 2019
a7abf61
Fix line breaking error.
DingkunLiu Oct 31, 2019
6bfe4b6
Revert "Fix line breaking error."
DingkunLiu Oct 31, 2019
6a9cdf1
Force line breaking to fix the rendering error on long code.
DingkunLiu Oct 31, 2019
97e6d55
Revert "Force line breaking to fix the rendering error on long code."
DingkunLiu Oct 31, 2019
c7f6a9f
Force line breaking to fix the rendering error on long code.
DingkunLiu Oct 31, 2019
81c8c09
Revert "Force line breaking to fix the rendering error on long code."
DingkunLiu Oct 31, 2019
de31e5f
Force line breaking to fix the rendering error on long code.
DingkunLiu Oct 31, 2019
32bbc7d
Revert "Force line breaking to fix the rendering error on long code."
DingkunLiu Oct 31, 2019
859b993
Fix render error
DingkunLiu Oct 31, 2019
4f99dd4
Render undocumented function as plain code.
DingkunLiu Oct 31, 2019
3843885
Fix sectioning.
DingkunLiu Nov 1, 2019
6453dd8
FIX: Formatting
larsoner Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*.swp
*.orig
build
.idea/

dist/
doc/_build/
Expand Down
6 changes: 5 additions & 1 deletion doc/_static/navy.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,4 +546,8 @@ ul.keywordmatches li.goodmatch a {
div.sphx-glr-footer-example a code span:last-child {
font-size: unset;
}
}
}

table.longtable.align-default {
width: 100%;
}
10 changes: 7 additions & 3 deletions surfer/tests/test_viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_annot():
view = get_view(brain)

for a, b, p in zip(annots, borders, alphas):
brain.add_annotation(a, b, p)
brain.add_annotation(a, b, p, opacity=0.8)
check_view(brain, view)

brain.set_surf('white')
Expand Down Expand Up @@ -226,7 +226,11 @@ def test_foci():
coords = [[-36, 18, -3],
[-43, 25, 24],
[-48, 26, -2]]
brain.add_foci(coords, map_surface="white", color="gold", name='test1')
brain.add_foci(coords,
map_surface="white",
color="gold",
name='test1',
resolution=25)

subj_dir = utils._get_subjects_dir()
annot_path = pjoin(subj_dir, subject_id, 'label', 'lh.aparc.a2009s.annot')
Expand Down Expand Up @@ -398,7 +402,7 @@ def test_overlay():
brain = Brain(*std_args)
brain.add_overlay(overlay_file)
brain.overlays["sig"].remove()
brain.add_overlay(overlay_file, min=5, max=20, sign="pos")
brain.add_overlay(overlay_file, min=5, max=20, sign="pos", opacity=0.7)
sig1 = io.read_scalar_data(pjoin(data_dir, "lh.sig.nii.gz"))
sig2 = io.read_scalar_data(pjoin(data_dir, "lh.alt_sig.nii.gz"))

Expand Down
Loading