FIX: Package version incorrect within Docker image#155
Merged
effigies merged 1 commit intonipreps:masterfrom Jan 17, 2020
Merged
FIX: Package version incorrect within Docker image#155effigies merged 1 commit intonipreps:masterfrom
effigies merged 1 commit intonipreps:masterfrom
Conversation
Member
|
From: https://1093-164755300-gh.circle-artifacts.com/0/tmp/ds005/derivatives/smriprep/sub-01.html
Git hash is right, but are we not using annotated tags, or what's the reason we're not seeing 0.4.1+? |
Member
Author
|
Okay, that is probably because my tags are out of sync and these tests are run on against my fork. However, I'm pretty positive that this patch should go in, please look at a docker build from master: https://app.circleci.com/jobs/github/poldracklab/smriprep/2274/parallel-runs/0/steps/0-105 and this is what the report shows https://2280-160736148-gh.circle-artifacts.com/0/tmp/ds005/derivatives/smriprep/sub-01.html#About (0+) |
Member
Author
I was outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the problem that sMRIPrep inside containers gives version 0+xxx
include_package_data = Truefrom thesetup.cfgfile.