-
Notifications
You must be signed in to change notification settings - Fork 5
WIP: Add partial volume correction workflow to PETPrep #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push main into add_petprep_pvc
Force push main into repo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
========================================
- Coverage 0.40% 0.39% -0.02%
========================================
Files 69 69
Lines 4893 5026 +133
Branches 533 540 +7
========================================
Hits 20 20
- Misses 4873 5006 +133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work branch introduces partial volume correction (PVC) workflow options. Documentation now clarifies that when PVC is enabled, the corrected images are aligned to anatomy and propagate through subsequent spatial normalization steps. The CLI initializes output spaces to include native T1w by default, and configuration now records the chosen PVC tool alongside method and PSF parameters.
PVC interfaces include updated label handling: Binarise4DSegmentation now preserves background labels, and CSVtoNifti expects the label list to contain background as the first entry. Workflow logic uses these corrected images as inputs for standard‑space derivatives. When PVC is enabled, the workflow forwards the method name to output datasinks so derivative files include a _pvc- entity.
Tests verify that the PVC method propagates to derivatives and that PVC‑corrected images feed into standard‑space workflows. Unit tests for segmentation focus on helper functions and node selection.
Major changes