Skip to content

RF: Use ReportCapableInterface from nipype #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 29, 2018
Merged

RF: Use ReportCapableInterface from nipype #238

merged 9 commits into from
May 29, 2018

Conversation

effigies
Copy link
Member

  • ReportCapableInputSpec -> SVGReportCapableInputSpec
  • Directly use Nipype's ReportCapableOutputSpec, ReportCapableInterface
  • Input trait inputs.generate_report is now instance attribute generate_report
  • _post_run_hook now generally ends with return super._post_run_hook

Depends on nipy/nipype#2560

This was referenced May 16, 2018
Merged
Merged
@effigies effigies force-pushed the rf/nipype_rci branch 3 times, most recently from 09c9cd0 to e52fd57 Compare May 17, 2018 17:04
@effigies effigies mentioned this pull request May 17, 2018
Merged
@effigies
Copy link
Member Author

Due to _post_run_hook in nipype proper, this is a precondition for #241. Upgrading the internal nipype to 1.0.4 and will pin fmriprep and mriqc against this branch for testing.

This was referenced May 29, 2018
Closed
Closed
@oesteban
Copy link
Member

Is this safe to merge in?

@effigies
Copy link
Member Author

If you're happy with it, tests seem to be passing.

@oesteban oesteban merged commit eff60f7 into nipreps:master May 29, 2018
@effigies effigies deleted the rf/nipype_rci branch May 30, 2018 00:23
@oesteban oesteban mentioned this pull request Jan 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @oesteban