-
Notifications
You must be signed in to change notification settings - Fork 301
[RTM] ENH: Conformation transforms #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in general this looks good, but in the freesurfer stream there is a way to get a transform back to the original input anatomical image. https://surfer.nmr.mgh.harvard.edu/fswiki/FsAnat-to-NativeAnat now that page has not been updated in a while and it would be good to check if the material still holds. |
Okay. My read from the earlier issue was that we didn't need to map back to the original T1w images.
We can definitely output the transforms from each input to the template; that's built into mri_robust_template. I guess the question is how to name these derivatives...
…-------- Original message --------
From: Satrajit Ghosh <notifications@github.com>
Date: 9/26/17 17:45 (GMT-05:00)
To: poldracklab/fmriprep <fmriprep@noreply.github.com>
Cc: Christopher Markiewicz <markiewicz@stanford.edu>, Author <author@noreply.github.com>
Subject: Re: [poldracklab/fmriprep] DOC: Add note about T1w space (#726)
in general this looks good, but in the freesurfer stream there is a way to get a transform back to the original input anatomical image. https://surfer.nmr.mgh.harvard.edu/fswiki/FsAnat-to-NativeAnat
now that page has not been updated in a while and it would be good to check if the material still holds.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#726 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAFF8pUhFWhzPQbV8aKK-lj929F8wByKks5smXBxgaJpZM4Pk2vW>.
|
a use case would be image-guided surgery. i'm not saying we should map back, but provide a way to map the data back. so just storing transforms would be sufficient i think. |
0e134aa
to
65a190d
Compare
Okay, as it is, this creates the following files: Single session:
Multi-session:
This was pretty easily manageable with our current derivatives plumbing. Now we can argue about what it should look like and figure out how to achieve it. Questions:
|
cc @oesteban @chrisfilo |
I like the clarification in the documentation, but I am not sure about the additional affine files. For example in the single session case: coregistration of which two files does Most importantly - question for @satra - is providing matrices that map between subject template and individual T1w files is a feature you currently need for some of your studies or something that you might see needing at some point in the future? I'm asking because we are overwhelmed with different work items and need to prioritise. |
65a190d
to
3e5e162
Compare
@chrisfilo - it depends on the project at hand. some are targeted at generating scanner aligned rois for realtime feedback. @effigies - your original note is fine, just that this notion of T1-space could be clarified. Is it some average space or is it aligned to the first one (see b below)? perhaps some questions that can help me get a better understanding : a. if we run our own freesurfer before fMRIprep is that still allowed? (we would like to do this for many reasons, we often run mindboggle separately, but also have datasets where we need to tweak freesurfer settings) mindboggle, for example, provides options for us to pass any recon-all flag to freesurfer b. when you say you average T1s, is this from multiple sessions or single session? if multiple, how do you account for actual variation between sessions that are not rigid-body. |
@satra It is still allowed to pre-run FreeSurfer. I will run vanilla |
Okay, pre-run FreeSurfer and fmriprep-run FreeSurfer do not register properly under the current scheme. This isn't simply a problem of adjusting our inputs to FreeSurfer or always building our template in the space of the first time point; the decision of which T1w image is the first time point can be made arbitrarily, so we can't make any assumptions. I think what we'll have to do is actually register the I think it's reasonable to assume a 7-dof (rigid + intensity) transform? |
@satra WRT your question (b), we use |
948bfd1
to
c34a7de
Compare
3c1ba9b
to
1024dcc
Compare
Since your last comment, @effigies, is there any development on the overall focus of this PR? I mean, I know you've gotten really deep into this issue during that time, so maybe you have a new perspective to this. Coming back to the origins:
And you implemented those ideas as follow:
This looks great to me, with only one worry. From
I'd say this is out of question. @satra mentioned some applications where this could be a game changer for FMRIPREP to be widely adopted.
I think we are in the right direction, probably @chrisfilo could give this a second thought.
FMRIPREP needs to aim at being cristal-clear for everything, so yes, this deserves their own documentation page. |
There are a couple changes to the implementation since the comment you're referencing. Instead of FSL-formatted The issue with the naming scheme you're discussing is that (Or am I misinterpreting? Is |
+1 to |
Added a line to the space table. Feel free to edit. |
Originally I did not intend to have both |
Yes.
…-------- Original message --------
From: Chris Filo Gorgolewski <notifications@github.com>
Date: 10/13/17 17:24 (GMT-05:00)
To: poldracklab/fmriprep <fmriprep@noreply.github.com>
Cc: Christopher Markiewicz <markiewicz@stanford.edu>, Mention <mention@noreply.github.com>
Subject: Re: [poldracklab/fmriprep] [WIP] ENH: Conformation transforms (#726)
Originally I did not intend to have both space and target in the same file. space was for imaging files and target was for transformation files. In this context did you mean space as source space?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#726 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAFF8nuDgML1BUuagcu_UXJ2emrgOdveks5sr9T1gaJpZM4Pk2vW>.
|
I like this for transformations. It is very explicit and easy to interpret. |
c3698e7
to
e9f7935
Compare
45092f3
to
a770188
Compare
@oesteban I think this is good to go, if you're okay with where it's currently putting files. Again, for reference, this is the location in the case of a single input (the transform will be the identity):
In the case of multiple images (e.g., from sessions
With a proposal that's been put forward on the list, we could in all cases store affines in
As the derivatives spec evolves, we can move in this direction, if that's preferred. (I think I would prefer it here, in the long term.) @satra Let us know if you have any objections to the current state of things. |
I took a little time to clean this up post 1.0.0-rc6, including some lessons learned regarding affine derivatives.
Current status:
T1w_preproc.nii.gz
)anat/
directoryDecisions going forward:
Open to critiques. @satra, this one's for you.
Closes #624.