Flake8 cleanup workflows/anatomical #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Maybe we bump minimum line length? I know its against the holy scripture for public code... Pylint only complains at 100 characters. But it also has some interesting ideas about what good looking code is that are not in pep8. |
|
I'm totally open to whatever standard you guys want to stick with. My only issue is that 79 characters is quite reduced, I would advocate for 99. |
effigies
force-pushed
the
pep8
branch
2 times, most recently
from
fae9a05 to
6e760d9
Compare
|
99 works. Added a Mostly finding some blank line counts and unused imports. A few undefined names, which I left alone, not knowing what they were supposed to be. |
|
Is this ready to merge? |
|
Yup.
Sent on my Samsung Galaxy S® 5
…-------- Original message --------
From: Oscar Esteban <notifications@github.com>
Date: 2/10/17 2:36 PM (GMT-05:00)
To: poldracklab/fmriprep <fmriprep@noreply.github.com>
Cc: Christopher Markiewicz <markiewicz@stanford.edu>, Author <author@noreply.github.com>
Subject: Re: [poldracklab/fmriprep] Flake8 cleanup workflows/anatomical (#350)
Is this ready to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#350 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAFF8kRcv75w9C8SH0hpDPq7mpsnSiyuks5rbLw8gaJpZM4LyAUt>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly line length and block spacing issues. These keep popping up when I style check before committing in #347, but I don't really want to infect that PR with these cleanups.
If people don't like these changes, can we put in a tox.ini or something to tell flake8 what style issues to report?