-
Notifications
You must be signed in to change notification settings - Fork 308
MAINT: Failing CI #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Failing CI #2401
Conversation
|
Okay, I looked into this a little more. A freeze of 20.2.1 (LTS) python versionsLooking at the docker build step more closely, we do have some incompatibilities... My inclination is to remove these by pinning to the following major/minors:
WDYT? |
|
I'm mostly okay relaxing the patch versions, but I'd really rather not keep pushing things. It seems that tedana 0.0.9 is doing most of the pushing, so what about the following?
|
|
I don't see how that will fix the problem we are currently running into: Skimming through the sklearn issue, it seems upgrading numpy to 1.16.* is the way. I'd prefer to get all the incompatibilities out of the way at once, but I'd settle for just numpy to get this (and #2400) in quicker. |
|
I'm proposing using an older skimage that is known to be compatible with the numpy series we have... |
|
I think we should still set @tsalo Would be interested in your thoughts here. |
effigies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nonetheless, okay with merging as is.
|
Opened #2402 - let's merge to get green again |
Seems to have been pinned to avoid a CI issue, not due to an actual incompatibility with newer version (nipreps#2401)
This updates the base images for our circle tests, and bumps the numpy and scipy versions as the one we're currently using is raising an error.
Given that this is the LTS branch, are we comfortable moving to a different minor of the above packages?