FIX: Output NaN columns for CompCor on failure #1456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status of this one? |
|
The tests were failing... I haven't had time to look at why, so I just reverted and reopened this PR as a reminder to get back to this. |
|
Can you recall whether the tests fail because of the problem building docs? Maybe a naive re-run would suffice? |
|
No. From the logs: This might be a bug in the nipype patch. Guess we should look before the next release. |
…t-1443-fix/compcor_nans
|
@rciric could you evaluate and inform as to whether this PR is still necessary or it has been superseded by your revision of the confounds? |
|
This PR has gone stale. Please follow up on the original issue (#1433) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores #1443