Skip to content

Conversation

@eilidhmacnicol
Copy link
Collaborator

@eilidhmacnicol eilidhmacnicol commented May 11, 2023

Changes proposed in this pull request

Despite attempts to address the problem in #54, the problem pointed out by @effigies persisted. This should address those problems and also adds the reusable anchors that were implemented in nipreps/fmriprep#2764

Documentation that should be reviewed

@eilidhmacnicol eilidhmacnicol marked this pull request as ready for review May 11, 2023 10:41
@eilidhmacnicol
Copy link
Collaborator Author

eilidhmacnicol commented May 11, 2023

Okay, still failing at the anatomical pipeline, but as I said in #54 (comment), that's expected because I bumped sMRIPrep and the workflow renaming happens in #55.

Have I missed anything, @effigies @mgxd?

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and seems to work.

@eilidhmacnicol eilidhmacnicol merged commit 65db418 into nipreps:master May 11, 2023
@eilidhmacnicol eilidhmacnicol deleted the ci/docker_local_registry branch May 11, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants