feat(autocomplete): use selected project for autocompleting resources #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The args only include the arguments of the current subcommand.
Otherwise it will break project auto-completion.
rnestler
reviewed
Jan 28, 2026
Comment on lines
+138
to
+140
| if (arg == "-p" || arg == "--project") && i+1 < len(args) { | ||
| return args[i+1] | ||
| } |
Contributor
There was a problem hiding this comment.
All nice and good, but did you test it? It doesn't actually work, for the reasons I stated in https://github.com/ninech/nctl/pull/334/changes#r2721243293
The args don't include the global flags like -p / --project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #334 with some improvements on edge cases and reading env variables.
Fixes #333
Closes #334